leveldb iterator should be deleted before the db is deleted #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Javelinjs can you check if this is addressed by #1748? If so this will be fixed once that is merged (soon). |
|
Should work fine in #1748 on account of automatic destructor order, but let me know if you think otherwise @Javelinjs. |
|
@shelhamer @longjon I think it works, just ignore this PR, thanks. |
|
Closing as fixed by #1748. Thanks for submitting a patch and checking @Javelinjs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some old version of leveldb, the iterator must be deleted before the db. Otherwise, it will cause a failure like:
compute_image_mean: version_set.cc:715: leveldb::VersionSet::~VersionSet(): Assertion `dummy_versions_.next_ == &dummy_versions_' failed.
./compute-mean.sh: line 2: 26811 Aborted ./build/tools/compute_image_mean train_leveldb mean.binaryproto leveldb
This is what I got on centos-6.5, rhel-6.5, with epel6 - leveldb-1.7.0-2.el6
Someone else had encountered the same problem, see https://groups.google.com/forum/#!topic/leveldb/I0_gN82a3vI